fix(options): Fix showing limit labels when pointer labels are always hidden #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hidden Previously limit labels would be hidden based on the position of the pointer labels even if user options hide pointer labels
Current coverage is 100%@@ master #373 diff @@
====================================
Files 1 1
Lines 842 844 +2
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 842 844 +2
Misses 0 0
Partials 0 0
|
|
Thanks for this PR, it looks good. I'm wondering if, when the hidePointerLabels is toggled at runtime, everything will work as expected. Indeed, if the option is off and the floor/ceil label is hidden because the pointer is next to it, and the option is turned on, the floor/ceil label will stay hidden while they should be visible... |
|
I'm away from computer until the end of the weekend so I'll try this scenario later. ;) |
|
Here's a JSFiddle which should demonstrate your use case. I believe it handles as expected. Below are concrete steps to test (as I understood them).
|
|
Indeed, this corresponds to what I was talking about. Good job! ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously limit labels would be hidden based on the position of the pointer labels even if user
options hide pointer labels.
This addresses #353